Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62833327
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/split/NumericBetweenParametersProvider.java
---
@@ -0,0 +1,70 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ * <p/>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p/>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.flink.api.java.io.jdbc.split;
+
+/**
+ *
+ * This query generator assumes that the query to parameterize contains a
BETWEEN constraint on a numeric column.
+ * The generated query set will be of size equal to the configured
fetchSize (apart the last one range),
+ * ranging from the min value up to the max.
+ *
+ * For example, if there's a table <CODE>BOOKS</CODE> with a numeric PK
<CODE>id</CODE>, using a query like:
+ * <PRE>
+ * SELECT * FROM BOOKS WHERE id BETWEEN ? AND ?
+ * </PRE>
+ *
+ * you can use this class to automatically generate the parameters of the
BETWEEN clause,
+ * based on the passed constructor parameters.
+ *
+ * */
+public class NumericBetweenParametersProvider implements
ParameterValuesProvider {
+
+ private static final long serialVersionUID = 1L;
+ private long fetchSize;
+ private final long min;
+ private final long max;
+
+ public NumericBetweenParametersProvider(long fetchSize, long min, long
max) {
+ this.fetchSize = fetchSize;
+ this.min = min;
+ this.max = max;
+ }
+
+ @Override
+ public Object[][] getParameterValues(){
+ double maxEelemCount = (max - min) + 1;
--- End diff --
typo in var name
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
