rmetzger commented on a change in pull request #15728:
URL: https://github.com/apache/flink/pull/15728#discussion_r628108052



##########
File path: 
flink-libraries/flink-state-processing-api/src/test/java/org/apache/flink/state/api/SavepointWindowReaderITCase.java
##########
@@ -348,24 +359,30 @@ public void testApplyWindowStateReader() throws Exception 
{
     public void testApplyEvictorWindowStateReader() throws Exception {
         String savepointPath =
                 takeSavepoint(
-                        numbers,
-                        source -> {
+                        WaitingWindowAssigner.wrap(
+                                
TumblingEventTimeWindows.of(Time.milliseconds(10))),
+                        (windowAssigner) -> {
                             StreamExecutionEnvironment env =
                                     
StreamExecutionEnvironment.getExecutionEnvironment();
                             env.setStateBackend(getStateBackend());
                             env.setParallelism(4);
 
-                            env.addSource(source)
-                                    .rebalance()
-                                    .assignTimestampsAndWatermarks(
-                                            
WatermarkStrategy.<Integer>noWatermarks()
-                                                    
.withTimestampAssigner((event, timestamp) -> 0))
-                                    .keyBy(id -> id)
-                                    
.window(TumblingEventTimeWindows.of(Time.milliseconds(10)))
-                                    .evictor(new NoOpEvictor<>())
-                                    .apply(new NoOpWindowFunction())
-                                    .uid(uid)
-                                    .addSink(new DiscardingSink<>());
+                            try {
+                                env.addSource(createSource(numbers))
+                                        .rebalance()
+                                        .assignTimestampsAndWatermarks(
+                                                
WatermarkStrategy.<Integer>noWatermarks()
+                                                        .withTimestampAssigner(
+                                                                (event, 
timestamp) -> 0))
+                                        .keyBy(id -> id)
+                                        .window(windowAssigner)
+                                        .evictor(new NoOpEvictor<>())
+                                        .apply(new NoOpWindowFunction())
+                                        .uid(uid)
+                                        .addSink(new DiscardingSink<>());
+                            } catch (Exception e) {
+                                e.printStackTrace();
+                            }

Review comment:
       Why are exceptions not logged via the logging framework?
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to