Github user mxm commented on the pull request:

    https://github.com/apache/flink/pull/1945#issuecomment-218736435
  
    Looks good. Do you think we could make this more explicit by passing the 
loaded configuration object to the `fetchConnectionInfo` method? That way we 
don't depend on global variables and we load the config only once.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to