dianfu commented on a change in pull request #15813:
URL: https://github.com/apache/flink/pull/15813#discussion_r629296621



##########
File path: 
flink-python/src/main/java/org/apache/flink/python/env/beam/ProcessPythonEnvironmentManager.java
##########
@@ -326,9 +327,21 @@ private void constructArchivesDirectory(Map<String, 
String> env) throws IOExcept
 
             // extract archives to archives directory
             for (Map.Entry<String, String> entry : 
dependencyInfo.getArchives().entrySet()) {
-                ZipUtils.extractZipFileWithPermissions(
-                        entry.getKey(),
-                        String.join(File.separator, archivesDirectory, 
entry.getValue()));
+                String filePath = entry.getKey();
+                if (filePath.endsWith(".zip") || filePath.endsWith(".jar")) {

Review comment:
       It would be great if we could support windows as I found that there are 
still quite a few users using window for development.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to