Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1979#discussion_r63047675
  
    --- Diff: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/triggers/Trigger.java
 ---
    @@ -169,7 +170,17 @@ public void clear(W window, TriggerContext ctx) throws 
Exception {}
                 *                                       function (function is 
not part os a KeyedStream).
                 */
                <S extends State> S getPartitionedState(StateDescriptor<S, ?> 
stateDescriptor);
    -   
    +
    +           /**
    +            *
    +            * Get an existing accumulator by <code>name</code> if it 
exists, Otherwise add <code>defaultAccumulator</code>.
    +            *
    +            * @param name Name of the accumulator
    +            * @param defaultAccumulator Accumulator to add, if no 
accumulator of the given name exists
    +            * @return The accumulator registered by the given 
<code>name</code> or the given default <code>defaultAccumulator</code>
    +            */
    +           public <V, A extends Serializable> Accumulator<V, A> 
getAccumulator(String name, 
org.apache.flink.api.common.accumulators.Accumulator<V, A> defaultAccumulator);
    --- End diff --
    
    `org.apache.flink.api.common.accumulators.Accumulator` can be shortened to 
`Accumulator`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to