rmetzger commented on a change in pull request #15884:
URL: https://github.com/apache/flink/pull/15884#discussion_r631893153
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/Executing.java
##########
@@ -60,8 +69,16 @@
this.context = context;
this.userCodeClassLoader = userCodeClassLoader;
- deploy();
-
+ if (executingStateBehavior == Behavior.DEPLOY_ON_ENTER) {
+ deploy();
+ } else if (executingStateBehavior == Behavior.EXPECT_RUNNING) {
+ Preconditions.checkState(
+ executionGraph.getState() == JobStatus.RUNNING,
+ "Assuming running execution graph");
+ } else {
+ throw new IllegalStateException(
+ "Unexpected executing state behavior " +
executingStateBehavior);
+ }
Review comment:
Having slept over this one night, I'm not so sure anymore if this is the
right approach. We can probably always assume the execution graph to be in
state RUNNING, and on `Behavior.EXPECT_RUNNING` we can go through all
ExecutionVertex and check if their state is running. I'll try to look into this
Monday morning latest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
