fapaul commented on a change in pull request #15799:
URL: https://github.com/apache/flink/pull/15799#discussion_r632633257
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherTest.java
##########
@@ -685,16 +684,16 @@ public void testJobSuspensionWhenDispatcherIsTerminated()
throws Exception {
assertThat(jobResultFuture.isDone(), is(false));
- dispatcher.closeAsync();
+ dispatcher.close();
- try {
- jobResultFuture.get();
- fail("Expected the job result to throw an exception.");
- } catch (ExecutionException ee) {
- assertThat(
- ExceptionUtils.findThrowable(ee,
JobNotFinishedException.class).isPresent(),
- is(true));
- }
+ final JobResult jobResult = jobResultFuture.get();
+ assertEquals(jobResult.getApplicationStatus(),
ApplicationStatus.UNKNOWN);
+
+ // Ensure that the suspended execution graph is accessible during
shutdown
+ final ExecutionGraphInfo executionGraphInfo =
+ dispatcher.requestExecutionGraphInfo(jobId, TIMEOUT).get();
Review comment:
Thanks for the hint. I added a new test submitting two jobs simulating
the scenario you've described.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]