lqjack commented on a change in pull request #15812:
URL: https://github.com/apache/flink/pull/15812#discussion_r634202976
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/slotpool/PhysicalSlotProviderImplWithSpreadOutStrategyTest.java
##########
@@ -105,16 +107,4 @@ public void testSlotAllocationFulfilledWithNewSlots()
physicalSlotProviderResource.registerSlotOffersFromNewTaskExecutor(ResourceProfile.ANY);
slotFuture.get();
}
-
- @Test
- public void
testIndividualBatchSlotRequestTimeoutCheckIsDisabledOnAllocatingNewSlots()
- throws Exception {
- TestingSlotPoolImpl slotPool =
- new
SlotPoolBuilder(physicalSlotProviderResource.getMainThreadExecutor()).build();
- assertThat(slotPool.isBatchSlotRequestTimeoutCheckEnabled(), is(true));
-
- new PhysicalSlotProviderImpl(
-
LocationPreferenceSlotSelectionStrategy.createEvenlySpreadOut(), slotPool);
- assertThat(slotPool.isBatchSlotRequestTimeoutCheckEnabled(),
is(false));
- }
Review comment:
I will rollback the test case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
