XComp opened a new pull request #15945:
URL: https://github.com/apache/flink/pull/15945
Additionally, I added a few Preconditions to the ExceptionHistoryEntry
creation
to make the code more robust.
## What is the purpose of the change
An `ExceptionHistoryEntry` referring to a local task failure can also have
the
TaskManagerLocation not being set (e.g. in cases where the task is not
deployed,
yet). The previous implementation failed in the REST endpoint in that case.
## Brief change log
The Precondition checking the availability of the `TaskManagerLocation` was
removed. The `ExceptionHistoryEntry.isGlobal` which is called before only
checks the availability of the task name.
Additionally, I added some Preconditions to make the code more robust and
added tests for these.
## Verifying this change
* A test was added to `JobExceptionsHandlerTest` to verify the issue
* Additional tests were added to `ExceptionHistoryEntryTest` to test the
Preconditions added to make `ExceptionHistoryEntry` more robust.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
