LadyForest opened a new pull request #15949:
URL: https://github.com/apache/flink/pull/15949
## What is the purpose of the change
This pull request supports `ALTER TABLE t RESET('key', ...)` syntax.
## Brief change log
- Extend `Parser.tdd` and `parserImpls.ftl` templates to support syntax. Add
`SqlAlterTableReset` to represent the SqlNode after parsing.
- Extend `SqlToOperationConverter` to convert `SqlAlterTableReset` to
`AlterTableOptionsOperation` by first cloning the table options of the current
resolved catalog table, and then removing the keys present in
`SqlAlterTableReset`.
- Add a util method `OperationConverterUtils#extractTableOptionKeys` to
extract table option keys from `SqlAlterTableReset`.
## Verifying this change
This change added tests and can be verified as follows:
- Added tests in `FlinkSqlParserImplTest` to verify parsing syntax correctly.
- Added cases in `SqlToOperatorConverterTest#testAlterTable` to verify
operation transforming behaves correctly.
- Added cases in `CatalogTableITCase` to verify the altered table options
are as expected.
- Added tests in `TableEnvironmentTest`.
`testAlterTableResetInvalidOptionKey` is to verify the RESET statement can fix
the invalid table options. `testAlterTableResetOptionalOptionKey` is to verify
the RESET statement can reset the table option key to its default value.
`testAlterTableResetRequiredOptionKey` is to verify the throwed exception when
reseting a required key.
- Added cases in the `table.q` to verify SqlCli behaves correctly.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no**
/ don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** /
don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (**yes** / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs
/ **not documented**)
- Docs will be updated after FLINK-22320 finishes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
