zentol commented on a change in pull request #15:
URL: https://github.com/apache/flink-jira-bot/pull/15#discussion_r635002752
##########
File path: flink_jira_rule.py
##########
@@ -32,32 +32,33 @@ def __init__(self, jira_client, config, is_dry_run):
self.done_label = config["done_label"].get()
self.done_comment = config["done_comment"].get()
self.warning_comment = config["warning_comment"].get()
+ self.ticket_limit = config["ticket_limit"].get()
- def get_issues(self, jql_query):
+ def get_issues(self, jql_query, limit):
"""Queries the JIRA PI for all issues that match the given JQL Query
This method is necessary as requests tend to time out if the number of
results reaches a certain number.
So, this method requests the results in multiple queries and returns a
final list of all issues.
:param jql_query: the search query
:return: a list of issues matching the query
"""
- limit = 200
+ limit_per_api_request = min(200, limit)
Review comment:
maybe set the upper limit to 100
##########
File path: config.yaml
##########
@@ -63,6 +67,7 @@ stale_critical:
This issue was labeled "{warning_label}" {warning_days} ago and has
not received any updates so it is being deprioritized. If this ticket is
actually Critical, please raise the priority and ask a committer to assign you
the issue or revive the public discussion.
stale_major:
+ ticket_limit: 15
Review comment:
these only add up to 50?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
