[
https://issues.apache.org/jira/browse/FLINK-3889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15286340#comment-15286340
]
ASF GitHub Bot commented on FLINK-3889:
---------------------------------------
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1984#issuecomment-219673873
Overall, the code looks very good! I had some inline comments about
Javadoc/comments.
One thing that might be wrong, though is the interplay between
`CheckpointableInputFormat.getCurrentChannelState()` and
`SplitReader.getReaderState()`. In the latter to check whether the result of
the former is null, and then do something based on this. The former, however
will never return `null` but instead always returns a `Tuple2` that can have
fields set to `null`. This might be an artifact form an earlier mode of
implementation.
> Make File Monitoring Function checkpointable.
> ---------------------------------------------
>
> Key: FLINK-3889
> URL: https://issues.apache.org/jira/browse/FLINK-3889
> Project: Flink
> Issue Type: Sub-task
> Components: Streaming
> Reporter: Kostas Kloudas
> Assignee: Kostas Kloudas
>
> This is essentially the combination of FLINK-3808 and FLINK-3717.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
