FuyaoLi2017 opened a new pull request #15961: URL: https://github.com/apache/flink/pull/15961
## What is the purpose of the change Flink documentation is migrated from Jekyll to Hugo through the PR [1], however, relevant LICENSE information is not updated in NOTICE file. This PR updates the dependencies to reflect the latest information. I also updated the fontawesome version to reflect the current version being used in Flink. In addition, bootstrap version 3.3.4 is known to have security vulnerabilities. See link [2]. I am not 100% sure about this change. I have a few questions and I am not sure about my assumptions below. - I didn't list the version of the hugo-book since it relies on Hugo and the version should be >=0.68 there [3]. - The `docs/themes/book` is linking to an external github repository with a commitID. The actual path you see on Github is `docs/themes/book @ a486adf` I didn't specify the commitID in the description here since it could also be misleading. When you pull the flink repo. This will be intepreted as `docs/themes/book` path. - There are some fourth party dependencies for hugo book. That includes KaTeX, Mermaid [4]. In [1], such license information is also mentioned in the commitID [5] but not merged into the Flink repo. As a result, I guess it is not necessary to list these fourth party libraries in this NOTICE, right? Thanks. cc @rmetzger @sjwiesman @wuchong [1] https://github.com/apache/flink/pull/14903 [2] https://snyk.io/test/npm/bootstrap/3.3.4 [3] https://github.com/alex-shpak/hugo-book/blob/a486adf8462c0abfc9034436ddd72927d6656809/README.md#requirements [4] https://github.com/alex-shpak/hugo-book/tree/a486adf8462c0abfc9034436ddd72927d6656809#shortcodes [5] https://github.com/apache/flink/commit/bfe9602c77c7ed1729335006194c97b6ddea3900 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
