[ 
https://issues.apache.org/jira/browse/FLINK-22719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17348084#comment-17348084
 ] 

Andy commented on FLINK-22719:
------------------------------

[~lzljs3620320], There exists multiple cases in WindowJoinTest to test those 
cases which window join condition is not valid. After I remove the exception 
thrown logical in WindowJoinUtil.containsWindowStartEqualityAndEndEquality, 
those cases also thrown a Exception,
{code:java}
aused by: org.apache.flink.table.api.TableException: Rowtime attributes must 
not be in the input rows of a regular join. As a workaround you can cast the 
time attributes of input tables to TIMESTAMP before.aused by: 
org.apache.flink.table.api.TableException: Rowtime attributes must not be in 
the input rows of a regular join. As a workaround you can cast the time 
attributes of input tables to TIMESTAMP before. at 
org.apache.flink.table.planner.plan.rules.physical.stream.StreamPhysicalJoinRule.matches(StreamPhysicalJoinRule.scala:78)
 at 
org.apache.calcite.plan.volcano.VolcanoRuleCall.matchRecurse(VolcanoRuleCall.java:284)
 at 
org.apache.calcite.plan.volcano.VolcanoRuleCall.matchRecurse(VolcanoRuleCall.java:411)
 at 
org.apache.calcite.plan.volcano.VolcanoRuleCall.matchRecurse(VolcanoRuleCall.java:411)
 at 
org.apache.calcite.plan.volcano.VolcanoRuleCall.match(VolcanoRuleCall.java:268) 
at 
org.apache.calcite.plan.volcano.VolcanoPlanner.fireRules(VolcanoPlanner.java:985)
 at 
org.apache.calcite.plan.volcano.VolcanoPlanner.registerImpl(VolcanoPlanner.java:1245)
 at 
org.apache.calcite.plan.volcano.VolcanoPlanner.register(VolcanoPlanner.java:589)
 at 
org.apache.calcite.plan.volcano.VolcanoPlanner.ensureRegistered(VolcanoPlanner.java:604)
 at 
org.apache.calcite.plan.volcano.VolcanoPlanner.ensureRegistered(VolcanoPlanner.java:84)
 at org.apache.calcite.rel.AbstractRelNode.onRegister(AbstractRelNode.java:268) 
at 
org.apache.calcite.plan.volcano.VolcanoPlanner.registerImpl(VolcanoPlanner.java:1132)
 at 
org.apache.calcite.plan.volcano.VolcanoPlanner.register(VolcanoPlanner.java:589)
 at 
org.apache.calcite.plan.volcano.VolcanoPlanner.ensureRegistered(VolcanoPlanner.java:604)
 at 
org.apache.calcite.plan.volcano.VolcanoPlanner.changeTraits(VolcanoPlanner.java:486)
 at org.apache.calcite.tools.Programs$RuleSetProgram.run(Programs.java:309) at 
org.apache.flink.table.planner.plan.optimize.program.FlinkVolcanoProgram.optimize(FlinkVolcanoProgram.scala:64)
 ... 45 more
{code}
 

> WindowJoinUtil.containsWindowStartEqualityAndEndEquality should not throw 
> exception
> -----------------------------------------------------------------------------------
>
>                 Key: FLINK-22719
>                 URL: https://issues.apache.org/jira/browse/FLINK-22719
>             Project: Flink
>          Issue Type: Bug
>          Components: Table SQL / Planner
>            Reporter: Jingsong Lee
>            Priority: Major
>             Fix For: 1.14.0
>
>
> This will broke regular join sql.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to