fsk119 commented on a change in pull request #15944:
URL: https://github.com/apache/flink/pull/15944#discussion_r635793767
##########
File path:
flink-end-to-end-tests/flink-tpch-test/src/main/java/org/apache/flink/table/tpch/TpchResultComparator.java
##########
@@ -81,7 +93,10 @@ public static void main(String[] args) throws IOException {
failed = (e * 0.99 > t || e * 1.01 < t);
}
} catch (NumberFormatException nfe2) {
- failed =
!expected[i].trim().equals(actual[i].trim());
+ failed =
+ !expected[i]
+ .trim()
+ .equals(actual[i].replaceAll("\"",
"").trim());
Review comment:
In the new data type system, we will use qoutoes for String type, e.g.
"string value", which is different from the behaviour before. Therefore, we
remove the quotes when we can't convert the value to `long` and `double`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
