xintongsong commented on pull request #15524: URL: https://github.com/apache/flink/pull/15524#issuecomment-845627262
Thanks for the review, @wangyang0918. Concerning re-registering AM on Yarn, I think it is indeed a problem. It looks like Yarn differentiate AMs by their attempt ids, and does not allow register multiple times for each AM. On the other hand, we need the registration response for finding existing containers. TBH, I don't see a good way to make the RM support multiple leader sessions on Yarn. On the other hand, I think the purpose of this PR is to avoid a RM making changes that only should be made by the leader before obtaining the leadership. Maybe it makes sense to scope supporting multiple leader sessions out of this PR. We can either completely remove changes related to supporting multiple leader sessions, or introduce a toggle for this feature that is by default disabled. I'm slightly leaning towards the latter, which makes it easier for us to trying this out in future efforts. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
