AHeise commented on a change in pull request #15771:
URL: https://github.com/apache/flink/pull/15771#discussion_r637027020
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/AbstractStreamOperator.java
##########
@@ -243,6 +240,13 @@ public void setup(
stateKeySelector2 = config.getStatePartitioner(1,
getUserCodeClassloader());
}
+ private CombinedWatermark setupCombinedWatermark() {
+ CombinedWatermark combinedWatermark = new CombinedWatermark();
+ combinedWatermark.add(new CombinedWatermark.PartialWatermark());
+ combinedWatermark.add(new CombinedWatermark.PartialWatermark());
Review comment:
Okay I'd still think that you could also hide that within
`#updateWatermark(..., boolean deferred)` but the benefit of encapsulation gets
even smaller (if it even still exists). So leave as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
