[ 
https://issues.apache.org/jira/browse/FLINK-22770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351033#comment-17351033
 ] 

Ingo Bürk edited comment on FLINK-22770 at 5/25/21, 12:44 PM:
--------------------------------------------------------------

In this first step we'd add SET/RESET to the grammar (requiring quotes for 
key/value), but keep the regex-based step in ExtendedParser. Since 
ExtendedParser is tried first, this will preserve backwards compatibility.

We could then keep support for both quoted and unquoted, deprecate the unquoted 
usage and remove it in a later release.


was (Author: airblader):
In this first step we'd add SET/RESET to the grammar (requiring quotes for 
key/value), but keep the regex-based step in ExtendedParser. Since 
ExtendedParser is tried first, this will preserve backwards compatibility.

> Expose SET/RESET from the parser
> --------------------------------
>
>                 Key: FLINK-22770
>                 URL: https://issues.apache.org/jira/browse/FLINK-22770
>             Project: Flink
>          Issue Type: New Feature
>          Components: Table SQL / API, Table SQL / Planner
>    Affects Versions: 1.13.0
>            Reporter: Ingo Bürk
>            Assignee: Ingo Bürk
>            Priority: Minor
>
> The SET/RESET statements (DCL¹) are currently implemented using regular 
> expressions in the ExtendedParser. They should instead be properly added to 
> the grammar and parser.
> In a second step, the ExtendedParser implementation for it can be removed. 
> However, this would be a breaking change as key/value would then have to be 
> quoted (as they are in other places, i.e. table options) and no longer be 
> treated as SQL identifiers.
> ¹ SET also exists in a no-argument version where it becomes DQL. For the 
> scope of this issue I'm excluding this here.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to