[
https://issues.apache.org/jira/browse/FLINK-13400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351102#comment-17351102
]
Timo Walther commented on FLINK-13400:
--------------------------------------
I agree with [~lirui]. We should add dedicated end-to-end tests that combines
SQL Client and Hive. The SQL Client module should be an independent entity.
Actually, we have infrastructure to do this nowadays, please have a look at the
newer e2e tests. We are doing this already for Kafka + SQL Client. Those are
perfectly suited to combine multiple Flink modules for testing.
Regarding "cost us a lot of time but the benefit maybe small", I'm currently
fixing several vulnerability issues for customers that are pulled in via Hadoop
and Hive. Every module without a Hadoop and Hive dependency is saving us time
in the long run. +1 for splitting this issue into subtasks and staring with the
simply "everything in test scope" fix.
> Remove Hive and Hadoop dependencies from SQL Client
> ---------------------------------------------------
>
> Key: FLINK-13400
> URL: https://issues.apache.org/jira/browse/FLINK-13400
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / Client
> Reporter: Timo Walther
> Priority: Critical
> Labels: auto-unassigned, stale-critical
> Fix For: 1.14.0
>
>
> 340/550 lines in the SQL Client {{pom.xml}} are just around Hive and Hadoop
> dependencies. Hive has nothing to do with the SQL Client and it will be hard
> to maintain the long list of exclusion there. Some dependencies are even in
> a {{provided}} scope and not {{test}} scope.
> We should remove all dependencies on Hive/Hadoop and replace catalog-related
> tests by a testing catalog. Similar to how we tests source/sinks.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
