[
https://issues.apache.org/jira/browse/FLINK-20716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351679#comment-17351679
]
Jin Xing commented on FLINK-20716:
----------------------------------
InputChannel is a part of "pluggable shuffle service". A possible fix would be
decouple it with SingleInputGate:
1. Add new methods of IndexedInputGate#notifyChannelNonEmpty and
IndexedInputGate#notifyPriorityEvent for channel notifications;
2. InputChannel accept a IndexedInputGate rather than a SingleInputGate in
constructor
3. In methods of InputChannel#notifyChannelNonEmpty and
InputChannel#notifyPriorityEvent, IndexedInputGate is invoked.
[~pnowojski] would you please help on this ~~ ?
> Pluggable shuffle service public interface IndexedInputGate mixed with Netty
> shuffle service implementation.
> ------------------------------------------------------------------------------------------------------------
>
> Key: FLINK-20716
> URL: https://issues.apache.org/jira/browse/FLINK-20716
> Project: Flink
> Issue Type: Sub-task
> Components: Runtime / Coordination
> Reporter: Jin Xing
> Priority: Minor
> Labels: auto-deprioritized-major
>
> In current "pluggable shuffle service", IndexedInputGate defines the reading
> for a single intermediate result (doc of InputGate) and InputChannel defines
> a single reading channel in IndexedInputGate. IndexedInputGate consists of a
> number of InputChanels. Current fields of InputChannel are mainly some
> descriptions or metrics for a single channel. But we found SingleInputGate is
> mixed in. From our understanding, SingleInputGate is a specific
> implementation in "Netty shuffle service" and should not be exposed by
> "pluggable shuffle service".
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
