rkhachatryan commented on a change in pull request #15200:
URL: https://github.com/apache/flink/pull/15200#discussion_r640987228
##########
File path:
flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogMapState.java
##########
@@ -71,22 +94,67 @@ public boolean contains(UK key) throws Exception {
@Override
public Iterable<Map.Entry<UK, UV>> entries() throws Exception {
- return delegatedState.entries();
+ Iterator<Map.Entry<UK, UV>> iterator =
delegatedState.entries().iterator();
+ final N currentNamespace = getCurrentNamespace();
+ return () ->
+ loggingIterator(
+ new Iterator<Map.Entry<UK, UV>>() {
+ @Override
+ public Map.Entry<UK, UV> next() {
+ return loggingMapEntry(
+ iterator.next(),
+ changeLogger,
+ changeWriter,
+ currentNamespace);
+ }
+
+ @Override
+ public boolean hasNext() {
+ return iterator.hasNext();
+ }
+
+ @Override
+ public void remove() {
+ iterator.remove();
+ }
+ },
+ changeLogger,
+ changeWriter,
+ currentNamespace);
}
@Override
public Iterable<UK> keys() throws Exception {
- return delegatedState.keys();
+ return loggingIterable(
+ delegatedState.keys(), changeLogger, this::serializeKey,
getCurrentNamespace());
}
@Override
public Iterable<UV> values() throws Exception {
- return delegatedState.values();
+ Iterator<Map.Entry<UK, UV>> iterator = entries().iterator();
+ return () ->
+ new Iterator<UV>() {
+ @Override
+ public boolean hasNext() {
+ return iterator.hasNext();
+ }
+
+ @Override
+ public UV next() {
+ return iterator.next().getValue();
+ }
+
+ @Override
+ public void remove() {
+ iterator.remove();
+ }
+ };
}
@Override
public Iterator<Map.Entry<UK, UV>> iterator() throws Exception {
- return delegatedState.iterator();
+ return loggingIterator(
+ delegatedState.iterator(), changeLogger, changeWriter,
getCurrentNamespace());
}
Review comment:
Good point, it can be changed via `MapEntry.setValue`.
I'll reuse the code from `entries()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
