[
https://issues.apache.org/jira/browse/FLINK-22794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17352972#comment-17352972
]
Shengkai Fang commented on FLINK-22794:
---------------------------------------
Thanks for your investigation. +1 to upgrade the junit-vintage-engine to the
new version 5.7.2 or 5.6.3
> flink-sql-parser and flink-sql-hive-parser
> -------------------------------------------
>
> Key: FLINK-22794
> URL: https://issues.apache.org/jira/browse/FLINK-22794
> Project: Flink
> Issue Type: Improvement
> Components: API / Core, Table SQL / API
> Affects Versions: 1.14.0
> Reporter: WeiNan Zhao
> Priority: Critical
> Fix For: 1.14.0
>
>
> In FLINK-22778,set junit.version:4.13.2,it cause flink-sql-parser test work
> failed.
> and now
> junit-jupiter-engine:{color:#ff0000}5.5.2;{color}junit-vintage-engine:{color:#ff0000}5.5.2.{color}
> {color:#172b4d}org.junit.vintage.engine.JUnit4VersionCheck#parseVersion
> cannot identify the version number correctly,{color}{color:#172b4d}e.g
> 4.13.2.{color}
> {color:#172b4d}so we can update sql-parser and sql-hive-parser to 5.7.0 at
> least.{color}
> {color:#172b4d}below is release note:{color}
> h3. JUnit Vintage
> h4. Bug Fixes
> * The Vintage engine no longer fails when resolving a {{MethodSelector}} for
> methods of test classes that cannot be found via reflection. This allows
> selecting Spock feature methods by their source code name even though they
> have a generated method name in the bytecode.
> h4. New Features and Improvements
> * {color:#de350b}The internal {{JUnit4VersionCheck}} class — which verifies
> that a supported version of JUnit 4 is on the classpath — now implements a
> lenient version ID parsing algorithm in order to support custom version ID
> formats such as {{4.12.0}}, {{4.12-patch_1}}, etc.{color}
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
