Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1947#issuecomment-220014866
Few followups are actually needed before merging this:
1. We need to remove the example metrics
2. Conflicting metrics names should not result in failures. Metrics are
tooling, and problems in the tooling should not fail the core programs.
3. I think we should limit the available metrics types to Gauge and
Counter for now. I looked at Timers, Meters, and Histograms - they are very
high overhead each. As a follow-up, I would like to see if we can construct
simple Meters as views over counters. That way, the runtime code as no overhead
for the metering (it just maintains counters and gauges) and the registry code
needs to turn them into Meters asynchronously.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
