SteNicholas commented on a change in pull request #16023:
URL: https://github.com/apache/flink/pull/16023#discussion_r642410508
##########
File path:
flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/common/RMQConnectionConfig.java
##########
@@ -29,21 +29,24 @@
import java.security.KeyManagementException;
import java.security.NoSuchAlgorithmException;
import java.util.Optional;
+import java.util.concurrent.TimeUnit;
/**
* Connection Configuration for RMQ. If {@link Builder#setUri(String)} has
been set then {@link
* RMQConnectionConfig#RMQConnectionConfig(String, Integer, Boolean, Boolean,
Integer, Integer,
- * Integer, Integer, Integer)} will be used for initialize the RMQ connection
or {@link
+ * Integer, Integer, Integer, Integer)} will be used for initialize the RMQ
connection or {@link
* RMQConnectionConfig#RMQConnectionConfig(String, Integer, String, String,
String, Integer,
- * Boolean, Boolean, Integer, Integer, Integer, Integer, Integer)} will be
used for initialize the
- * RMQ connection
+ * Boolean, Boolean, Integer, Integer, Integer, Integer, Integer, Integer)}
will be used for
+ * initialize the RMQ connection
*/
public class RMQConnectionConfig implements Serializable {
private static final long serialVersionUID = 1L;
private static final Logger LOG =
LoggerFactory.getLogger(RMQConnectionConfig.class);
+ private static final int DEFAULT_DELIVERY_TIMEOUT = 30000;
Review comment:
My point of concern is why the default value is 30 seconds, and what is
the basis for the default value of 30 seconds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
