Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1220#issuecomment-220083900
The PR looks good to me. The only think which could be good to get rid of
is the requirement that you have to select a Euclidean distance for the
quadtree. Maybe there is some other characteristic for a distance measure which
says whether it's applicable for quadtrees or not. Then we could introduce a
new distance metric type to make sure that only appropriate distance measures
are used. But this should not be a blocker for merging this PR.
Thanks for your contribution @danielblazevski. Really good work :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
