JingsongLi commented on a change in pull request #13921:
URL: https://github.com/apache/flink/pull/13921#discussion_r642806420
##########
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecRank.java
##########
@@ -207,18 +211,42 @@ public StreamExecRank(
AbstractTopNFunction processFunction;
if (rankStrategy instanceof RankProcessStrategy.AppendFastStrategy) {
- processFunction =
- new AppendOnlyTopNFunction(
- minIdleStateRetentionTime,
- maxIdleStateRetentionTime,
- inputRowTypeInfo,
- sortKeyComparator,
- sortKeySelector,
- rankType,
- rankRange,
- generateUpdateBefore,
- outputRankNumber,
- cacheSize);
+ boolean isAppendOnlyFirstN = false;
+ if (sortFields.length == 1) {
+ LogicalType sortKeyType =
inputType.getChildren().get(sortFields[0]);
+ if (sortKeyType instanceof LocalZonedTimestampType
Review comment:
`TypeCheckUtils.isProcTime`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
