twalthr commented on a change in pull request #16037:
URL: https://github.com/apache/flink/pull/16037#discussion_r642845926
##########
File path: flink-connectors/flink-sql-connector-hive-3.1.2/pom.xml
##########
@@ -69,10 +69,56 @@ under the License.
<artifactId>antlr-runtime</artifactId>
<version>3.5.2</version>
</dependency>
+
+ <!-- hadoop deps to make the copied code compile -->
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-mapreduce-client-core</artifactId>
+ <version>2.8.2</version>
Review comment:
use Flink's Hadoop version variable?
##########
File path: tools/maven/suppressions.xml
##########
@@ -82,4 +82,7 @@ under the License.
<suppress
files="org[\\/]apache[\\/]flink[\\/]formats[\\/]avro[\\/]glue[\\/]schema[\\/]registry[\\/]User.java"
checks=".*"/>
+ <!-- suppress check for copied hive code -->
+ <suppress files="HiveConf.java" checks="[a-zA-Z0-9]*"/>
Review comment:
Make this less specific because otherwise we might forget to drop it in
the future. We can simply do a `org.apache.hive` exclusion.
##########
File path: flink-connectors/flink-sql-connector-hive-3.1.2/pom.xml
##########
@@ -69,10 +69,56 @@ under the License.
<artifactId>antlr-runtime</artifactId>
<version>3.5.2</version>
</dependency>
+
+ <!-- hadoop deps to make the copied code compile -->
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-mapreduce-client-core</artifactId>
+ <version>2.8.2</version>
+ <exclusions>
+ <exclusion>
+ <groupId>log4j</groupId>
+ <artifactId>log4j</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-log4j12</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+
+ <!-- avro is included in hive-exec. we use the same dependencies but
with a different version -->
+ <dependency>
+ <groupId>org.apache.avro</groupId>
+ <artifactId>avro</artifactId>
+ <version>1.8.2</version>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.avro</groupId>
+ <artifactId>avro-mapred</artifactId>
+ <classifier>hadoop2</classifier>
+ <version>1.8.2</version>
Review comment:
Do we need to update some NOTICE files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
