[
https://issues.apache.org/jira/browse/FLINK-21439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355471#comment-17355471
]
John Phelan commented on FLINK-21439:
-------------------------------------
Okay I think I see how you are looking at it. I reused
{{FailureHandlingResultSnapshot}} so that from {{AdaptiveScheduler}} there is
no {{FailureHandlingResult}} being snapshotted but there is still a
{{FailureHandlingResultSnapshot}} produced. Maybe we can change the name of
this class now?
Summary of patch:
- two tests in {{AdaptiveSchedulerTest}} for knowing the specific failing task
and for not knowing.
- added the history queue to {{AdaptiveScheduler}} along with {{requestJob}}
- added archiveExecutionFailure
to StateWithExecutionGraph to populate the queue in {{AdaptiveScheduler}} along
with uses of this method in {{archiveAnyFailure}} in {{Executing}} and
{{StopWithSavepoint}}.
> Maybe {{Executing}} and {{StopWithSavepoint}} shouldn't always call
> {{archiveExecutionFailure}} as I have in the PR?
- I added a {{FailureHandlingResultSnapshot}} factory method that accepts what
we have available in {{AdaptiveScheduler}} when we have failures. I think maybe
it's a broader type of {{FailureSnapshot}} now. Should we rename the class?
PTAL
> Adaptive Scheduler: Add support for exception history
> -----------------------------------------------------
>
> Key: FLINK-21439
> URL: https://issues.apache.org/jira/browse/FLINK-21439
> Project: Flink
> Issue Type: Improvement
> Components: Runtime / Coordination
> Affects Versions: 1.13.0
> Reporter: Matthias
> Assignee: John Phelan
> Priority: Major
> Labels: pull-request-available, reactive
> Time Spent: 3h
> Remaining Estimate: 0h
>
> {{SchedulerNG.requestJob}} returns an {{ExecutionGraphInfo}} that was
> introduced in FLINK-21188. This {{ExecutionGraphInfo}} holds the information
> about the {{ArchivedExecutionGraph}} and exception history information.
> Currently, it's a list of {{ErrorInfos}}. This might change due to ongoing
> work in FLINK-21190 where we might introduced a wrapper class with more
> information on the failure.
> The goal of this ticket is to implement the exception history for the
> {{AdaptiveScheduler}}, i.e. collecting the exceptions that caused restarts.
> This collection of failures should be forwarded through
> {{SchedulerNG.requestJob}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
