Airblader commented on a change in pull request #16049:
URL: https://github.com/apache/flink/pull/16049#discussion_r643684874
##########
File path:
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/SqlClient.java
##########
@@ -179,6 +179,8 @@ protected static void startClient(String[] args,
Supplier<Terminal> terminalFact
switch (mode) {
case MODE_EMBEDDED:
final CliOptions options =
CliOptionsParser.parseEmbeddedModeClient(modeArgs);
+ // check arg e.g -i -f
+ checkArgs(args);
Review comment:
In the line above the args are already parsed into `CliOptions`.
Wouldn't it be easier and better to do the validation on that object so we can
avoid parsing the arguments (i.e. "-i", "-f") again in `checkArgs`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
