[ 
https://issues.apache.org/jira/browse/FLINK-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290781#comment-15290781
 ] 

ASF GitHub Bot commented on FLINK-3836:
---------------------------------------

Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1966#discussion_r63847905
  
    --- Diff: 
flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/testutils/MockRuntimeContext.java
 ---
    @@ -148,6 +149,11 @@ public Histogram getHistogram(String name) {
        }
     
        @Override
    +   public LongHistogram getLongHistogram(String name) {
    --- End diff --
    
    I think we should try and not have utility methods for each accumulator 
type in the runtime context - it becomes a lot otherwise. The methods for 
`getHistogram()` etc are also marked as public evolving, because they may 
possibly be removed in the future.


> Change Histogram to enable Long counters
> ----------------------------------------
>
>                 Key: FLINK-3836
>                 URL: https://issues.apache.org/jira/browse/FLINK-3836
>             Project: Flink
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.0.2
>            Reporter: Maximilian Bode
>            Assignee: Maximilian Bode
>            Priority: Minor
>
> Change 
> flink/flink-core/src/main/java/org/apache/flink/api/common/accumulators/Histogram.java
>  to enable Long counts instead of Integer. In particular, change the TreeMap 
> to be <Integer, Long>.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to