[
https://issues.apache.org/jira/browse/FLINK-17495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17356547#comment-17356547
]
Mason Chen commented on FLINK-17495:
------------------------------------
Hi [~chesnay], this is Mason from the mailing list. I would like to take on
this ticket as a contribution to OSS.
My initial thoughts on implementation:
* Users should be able to pass this configuration as part of the "flink
configuration" like the other metrics configs.
* ReporterScopedSettings seems like a good place to communicate this config to
all the reporters.
* Some reporters already have this feature (Datadog reporter), so those
specific reporters can read the ReporterScopedSettings and, if not present,
then use the their reporter specific configuration. We should remove the
redundant configs, eventually.
> Add support for custom variables
> --------------------------------
>
> Key: FLINK-17495
> URL: https://issues.apache.org/jira/browse/FLINK-17495
> Project: Flink
> Issue Type: Improvement
> Components: Runtime / Metrics
> Reporter: jinhai
> Priority: Minor
> Labels: auto-deprioritized-major, pull-request-available
>
> Allow users to configure additional labels, presumably via a new config
> option {{metrics.scope.variables.add.}}
> E.g.,
> {code:java}
> metrics.scope.variables.add: key1:value1;key2:value2 {code}
> Configured variables should be added to the variables map of the root metric
> group; this may allow us in the future (once we have generalized scope
> formats a bit) to include them there as well.
>
> Original description:
> {quote}We need to add some custom labels on Prometheus, so we can query by
> them.?? ??
> Now we can add jobName\groupingKey to PrometheusPushGatewayReporter in
> version 1.10, but not in PrometheusReporter.
> Can we add AbstractPrometheusReporter#addDimension method to support this, so
> they will be no differences except for the metrics exposing mechanism
> pulling/pushing.
> {quote}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
