[
https://issues.apache.org/jira/browse/FLINK-3893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290855#comment-15290855
]
ASF GitHub Bot commented on FLINK-3893:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2009#discussion_r63854365
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/TestingLeaderRetrievalService.java
---
@@ -61,8 +61,6 @@ public void stop() throws Exception {
public void notifyListener(String address, UUID leaderSessionID) {
if (listener != null) {
listener.notifyLeaderAddress(address, leaderSessionID);
- } else {
- throw new IllegalStateException("The retrieval service
has not been started properly.");
--- End diff --
the commit name doesn't seem to properly reflect the change made; it should
be "don't fail if ... service has _not_ been started"
> LeaderChangeStateCleanupTest times out
> --------------------------------------
>
> Key: FLINK-3893
> URL: https://issues.apache.org/jira/browse/FLINK-3893
> Project: Flink
> Issue Type: Bug
> Components: Tests
> Affects Versions: 1.1.0
> Reporter: Maximilian Michels
> Assignee: Maximilian Michels
> Priority: Minor
> Labels: test-stability
>
> {{cluster.waitForTaskManagersToBeRegistered();}} needs to be replaced by
> {{cluster.waitForTaskManagersToBeRegistered(timeout);}}
> {noformat}
> testStateCleanupAfterListenerNotification(org.apache.flink.runtime.leaderelection.LeaderChangeStateCleanupTest)
> Time elapsed: 10.106 sec <<< ERROR!
> java.util.concurrent.TimeoutException: Futures timed out after [10000
> milliseconds]
> at scala.concurrent.impl.Promise$DefaultPromise.ready(Promise.scala:219)
> at scala.concurrent.impl.Promise$DefaultPromise.ready(Promise.scala:153)
> at scala.concurrent.Await$$anonfun$ready$1.apply(package.scala:86)
> at scala.concurrent.Await$$anonfun$ready$1.apply(package.scala:86)
> at
> scala.concurrent.BlockContext$DefaultBlockContext$.blockOn(BlockContext.scala:53)
> at scala.concurrent.Await$.ready(package.scala:86)
> at
> org.apache.flink.runtime.minicluster.FlinkMiniCluster.waitForTaskManagersToBeRegistered(FlinkMiniCluster.scala:455)
> at
> org.apache.flink.runtime.minicluster.FlinkMiniCluster.waitForTaskManagersToBeRegistered(FlinkMiniCluster.scala:439)
> at
> org.apache.flink.runtime.leaderelection.LeaderChangeStateCleanupTest.testStateCleanupAfterListenerNotification(LeaderChangeStateCleanupTest.java:181)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
