akalash commented on a change in pull request #16050:
URL: https://github.com/apache/flink/pull/16050#discussion_r645365324
##########
File path:
flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogKeyedStateBackend.java
##########
@@ -75,7 +76,8 @@
class ChangelogKeyedStateBackend<K>
implements CheckpointableKeyedStateBackend<K>,
CheckpointListener,
- TestableKeyedStateBackend {
+ TestableKeyedStateBackend,
+ DelegatingKeyedStateBackend<K> {
Review comment:
As I understand this PR is only one part of the whole change, and
perhaps, I don't see the full picture. But according to this PR
DelegatingKeyedStateBackend is using only for the tests and maybe it makes
sense to move it into TestableKeyedStateBackend because right now, I see two
interfaces specifically for the test(DelegatingKeyedStateBackend and
TestableKeyedStateBackend) and I don't sure that it makes sense. But of course,
if DelegatingKeyedStateBackend will be used somewhere else in the production
code, then I don't have any questions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
