Myasuka commented on a change in pull request #15200:
URL: https://github.com/apache/flink/pull/15200#discussion_r646166423
##########
File path:
flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogListState.java
##########
@@ -39,53 +44,83 @@
extends AbstractChangelogState<K, N, List<V>, InternalListState<K, N,
V>>
implements InternalListState<K, N, V> {
- ChangelogListState(InternalListState<K, N, V> delegatedState) {
- super(delegatedState);
+ ChangelogListState(
+ InternalListState<K, N, V> delegatedState,
+ KvStateChangeLogger<List<V>, N> changeLogger) {
+ super(delegatedState, changeLogger);
}
@Override
public void update(List<V> values) throws Exception {
+ changeLogger.valueUpdated(values, getCurrentNamespace());
delegatedState.update(values);
}
@Override
public void addAll(List<V> values) throws Exception {
+ changeLogger.valueAdded(values, getCurrentNamespace());
delegatedState.addAll(values);
}
@Override
public void updateInternal(List<V> valueToStore) throws Exception {
+ changeLogger.valueUpdated(valueToStore, getCurrentNamespace());
delegatedState.updateInternal(valueToStore);
}
@Override
public void add(V value) throws Exception {
+ if (getValueSerializer() instanceof ListSerializer) {
+ changeLogger.valueElementChanged(
+ w ->
+ ((ListSerializer<V>) getValueSerializer())
+ .getElementSerializer()
+ .serialize(value, w),
+ getCurrentNamespace());
+ } else {
+ changeLogger.valueAdded(singletonList(value),
getCurrentNamespace());
Review comment:
I wonder is it possible that the value serializer of chenagelogList
state is not a `ListSerializer`?
##########
File path:
flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogAggregatingState.java
##########
@@ -67,18 +73,24 @@ public OUT get() throws Exception {
@Override
public void add(IN value) throws Exception {
delegatedState.add(value);
+ changeLogger.valueUpdated(delegatedState.getInternal(),
getCurrentNamespace());
Review comment:
The same as `ChangelogReducingState`, update changelog first and then
add to delegated state.
##########
File path:
flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogReducingState.java
##########
@@ -65,16 +72,24 @@ public V get() throws Exception {
@Override
public void add(V value) throws Exception {
delegatedState.add(value);
+ changeLogger.valueUpdated(delegatedState.get(), getCurrentNamespace());
Review comment:
we should first update changelog and then adding to the delegated state.
##########
File path:
flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogMapState.java
##########
@@ -51,16 +63,28 @@ public UV get(UK key) throws Exception {
@Override
public void put(UK key, UV value) throws Exception {
+ if (getValueSerializer() instanceof MapSerializer) {
+ changeLogger.valueElementChanged(
+ out -> {
+ serializeKey(key, out);
+ serializeValue(value, out);
+ },
+ getCurrentNamespace());
+ } else {
+ changeLogger.valueAdded(singletonMap(key, value),
getCurrentNamespace());
Review comment:
I wonder is it possible that the value serializer of chenagelogMap state
is not a `MapSerializer`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
