zentol commented on a change in pull request #16081:
URL: https://github.com/apache/flink/pull/16081#discussion_r647260635
##########
File path: tools/azure-pipelines/jobs-template.yml
##########
@@ -208,10 +208,10 @@ jobs:
continueOnError: true
condition: not(eq(variables['SKIP'], '1'))
- script: |
- echo "##vso[task.setvariable variable=JAVA_HOME]$JAVA_HOME_11_X64"
- echo "##vso[task.setvariable variable=PATH]$JAVA_HOME_11_X64/bin:$PATH"
- displayName: "Set to jdk11"
- condition: eq('${{parameters.jdk}}', 'jdk11')
+ echo "##vso[task.setvariable variable=JAVA_HOME]$JAVA_HOME_8_X64"
+ echo "##vso[task.setvariable variable=PATH]$JAVA_HOME_8_X64/bin:$PATH"
+ displayName: "Set to jdk8"
Review comment:
so jdk11 is the default nowadays?
##########
File path: flink-end-to-end-tests/test-scripts/common_kubernetes.sh
##########
@@ -108,7 +110,6 @@ function start_kubernetes {
exit 1
fi
fi
- eval $(minikube docker-env)
Review comment:
why do we no longer need this? (or did we never?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
