qingdao81 commented on pull request #15808:
URL: https://github.com/apache/flink/pull/15808#issuecomment-856822082


   @twalthr I updated the MR. I debugged the code and noticed that the 
`CachedSchemaRegistryClient` expects all properties in a dot notation and 
additional ssl related properties in the format: `schema.registry.ssl.xxx`
   and auth related properties in the format without the `schema.registry` 
prefix: `basic.auth.user.info`
   
   I still followed your suggestion to define config groups with the 
combination of dash / dot notation and transformed the Flink specific format to 
the Confluent specific format in 
`CachedSchemaCoderProvider#formatRegistryConfigs`.
   
   I removed the unit tests which were not really meaningful and added a some 
tests for basic and bearer auth.
   
   Happy to get your feedback!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to