rkhachatryan commented on a change in pull request #15200:
URL: https://github.com/apache/flink/pull/15200#discussion_r647622863
##########
File path:
flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogMapState.java
##########
@@ -51,16 +63,28 @@ public UV get(UK key) throws Exception {
@Override
public void put(UK key, UV value) throws Exception {
+ if (getValueSerializer() instanceof MapSerializer) {
+ changeLogger.valueElementChanged(
+ out -> {
+ serializeKey(key, out);
+ serializeValue(value, out);
+ },
+ getCurrentNamespace());
+ } else {
+ changeLogger.valueAdded(singletonMap(key, value),
getCurrentNamespace());
Review comment:
I see some checks in both Heap and RocksDB backends that disallow other
serializers.
But it seems an implementation detail and I'm not sure that we can depend on
it.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
