echauchot commented on a change in pull request #15725:
URL: https://github.com/apache/flink/pull/15725#discussion_r648487978
##########
File path:
flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/ParquetInputFormat.java
##########
@@ -160,13 +168,16 @@ public void setFilterPredicate(FilterPredicate
filterPredicate) {
public void open(FileInputSplit split) throws IOException {
// reset the flag when open a new split
this.skipThisSplit = false;
+ // TODO why is this needed to read the parquet schema from file in
open() ? Can't we use the
+ // already extracted schema (extracted in the constructor) ?
Review comment:
Yes, clearer now, thanks. But still I think there is a bug, see my
comment at the end of the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
