Airblader commented on a change in pull request #16046:
URL: https://github.com/apache/flink/pull/16046#discussion_r649149621
##########
File path:
flink-table/flink-table-common/src/test/java/org/apache/flink/table/types/inference/TypeStrategiesTest.java
##########
@@ -311,7 +315,21 @@
"Average without grouped aggregation",
TypeStrategies.aggArg0(LogicalTypeMerging::findAvgAggType, true))
.inputTypes(DataTypes.INT().notNull())
- .expectDataType(DataTypes.INT()));
+ .expectDataType(DataTypes.INT()),
+
+ // CURRENT_WATERMARK
+ TestSpec.forStrategy("TIMESTAMP(3) *ROWTIME*",
TypeStrategies.CURRENT_WATERMARK)
Review comment:
I couldn't really find a grouped cut that made sense (other than the
decimal ones), so I moved all specific strategies into their own class now and
split up the test as well. I settled for `INSTANCE` members to not add them all
to `TypeStrategies`, but we can also undo that. Let me know what you think of
this, I added it as a separate commit (also since it's kind of unrelated and
more drive-by refactoring).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
