[
https://issues.apache.org/jira/browse/FLINK-3632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15294838#comment-15294838
]
ASF GitHub Bot commented on FLINK-3632:
---------------------------------------
GitHub user yjshen opened a pull request:
https://github.com/apache/flink/pull/2015
[FLINK-3632][TableAPI]Clean up Table API exceptions
As suggested by @fhueske in
https://github.com/apache/flink/pull/1958#discussion_r62680699, we should use
`TableException` in the following cases:
- General invalid use of Table API
- registering a table with invalid field types and/or
- registering a table with already exist name
- Current limitations
- Unsupported types
- Unsupported features (Aggregate on stream table, etc.)
This PR tries to eliminate most of the `IllegalArgumentException` in Table
API.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yjshen/flink table_exception_cleanup
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2015.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2015
----
commit b54c0cfff6a275ab7eae8c516aa67572be237563
Author: Yijie Shen <[email protected]>
Date: 2016-05-18T15:57:42Z
clean up exceptions
----
> Clean up Table API exceptions
> -----------------------------
>
> Key: FLINK-3632
> URL: https://issues.apache.org/jira/browse/FLINK-3632
> Project: Flink
> Issue Type: Improvement
> Components: Table API
> Reporter: Fabian Hueske
> Assignee: Yijie Shen
> Fix For: 1.1.0
>
>
> The Table API throws many different exception types including:
> - {{IllegalArgumentException}}
> - {{TableException}}
> - {{CodeGenException}}
> - {{PlanGenException}}
> - {{ExpressionParserException}}
> from various places of the query translation code.
> This needs to be cleaned up.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
