SteNicholas opened a new pull request #16142:
URL: https://github.com/apache/flink/pull/16142


   ## What is the purpose of the change
   
   *We should allow to write to different Kafka topics based on some column 
value in SQL. The existing implementation can be easily adapted for that. The 
"target topic" would be an additional persisted metadata column in SQL terms. 
All one need to do is to adapt `DynamicKafkaSerializationSchema` and 
`KafkaDynamicSink`. We should guard this dynamic behavior via a metadata column 
and make the topic option optional in this case.*
   
   ## Brief change log
   
     - *`KafkaDynamicSink` adds the `topic` writable metadata column and make 
the `topic` option optional for `KafkaDynamicTableFactory`.*
     - *`DynamicKafkaSerializationSchema` serializes the row data to 
`ProducerRecord` via `topic` metadata column when the 'topic' table option is 
null.*
   
   ## Verifying this change
   
     - *`KafkaTableITCase` adds the 
`testKafkaSinkWithMetadataIncludeTopicOption` and 
`testKafkaSinkWithMetadataExcludeTopicOption` test methods to verify whether 
sink to Kafka through `topic` metadata column when the 'topic' table option is 
null.*
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** 
/ don't know)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / 
don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / 
JavaDocs / not documented)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to