twalthr commented on a change in pull request #16046: URL: https://github.com/apache/flink/pull/16046#discussion_r649724128
########## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/ArrayTypeStrategy.java ########## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.types.inference.strategies; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.table.api.DataTypes; +import org.apache.flink.table.types.DataType; +import org.apache.flink.table.types.inference.CallContext; +import org.apache.flink.table.types.inference.TypeStrategy; + +import java.util.List; +import java.util.Optional; + +/** + * Type strategy that returns a {@link DataTypes#ARRAY(DataType)} with element type equal to the + * type of the first argument. + */ +@Internal +public class ArrayTypeStrategy implements TypeStrategy { Review comment: I like this refactoring into dedicated classes. But still I think those should be package private, otherwise we are polluting the API classpath. This is `table-common` and many modules depend on this. I would suggest that we create a `SpecificTypeStrategies` class in this package as kind of a public bridge to the `BuiltInFunctionDefinitions` package. So we can move all `INSTANCE`s to this class and only one class will be visible in the classpath. ########## File path: flink-table/flink-table-api-scala/src/main/scala/org/apache/flink/table/api/ImplicitExpressionConversions.scala ########## @@ -445,6 +445,28 @@ trait ImplicitExpressionConversions { Expressions.currentTimestamp() } + /** + * Returns the current watermark for the given rowtime attribute, or <code>NULL</code> if no Review comment: Scala doesn't know HTML but uses markdown so you can drop `<p>` and `<code>` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
