wenlong88 commented on a change in pull request #16096:
URL: https://github.com/apache/flink/pull/16096#discussion_r651666576
##########
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/metadata/FlinkMetadata.java
##########
@@ -238,4 +239,20 @@ ImmutableBitSet getUniqueGroups(
RelWindowProperties getWindowProperties(RelNode r,
RelMetadataQuery mq);
}
}
+
+ /** Metadata about which combinations of columns are change log upsert
identifiers. */
+ public interface ChangeLogUpsertKeys extends Metadata {
+ Method METHOD = Types.lookupMethod(ChangeLogUpsertKeys.class,
"getChangeLogUpsertKeys");
+
+ MetadataDef<ChangeLogUpsertKeys> DEF =
+ MetadataDef.of(
+ ChangeLogUpsertKeys.class,
ChangeLogUpsertKeys.Handler.class, METHOD);
+
+ Set<ImmutableBitSet> getChangeLogUpsertKeys();
Review comment:
for the point 2, if the upsert key is f0(just the same the distribution
of the stream), hash(f0) can satisfy require of sink both (f0, f2) and (f0,
rank number), is it more intuitive?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]