fredia commented on a change in pull request #16168:
URL: https://github.com/apache/flink/pull/16168#discussion_r652513196
##########
File path:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackendBuilder.java
##########
@@ -363,6 +363,9 @@ private static void checkAndCreateDirectory(File directory)
throws IOException {
IOUtils.closeQuietly(optionsContainer);
ttlCompactFiltersManager.disposeAndClearRegisteredCompactionFactories();
kvStateInformation.clear();
+ if (checkpointStrategy != null) {
+ checkpointStrategy.close();
Review comment:
Couldn't agree more. Has been fixed with `closeQuietly`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
