[ 
https://issues.apache.org/jira/browse/FLINK-3955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15296709#comment-15296709
 ] 

ASF GitHub Bot commented on FLINK-3955:
---------------------------------------

GitHub user fhueske opened a pull request:

    https://github.com/apache/flink/pull/2023

    [FLINK-3955] [tableAPI] Rename Table.toSink() to Table.writeToSink().

    Renames `Table.toSink()` to `Table.writeToSink()`.
    
    `Table.toSink()` indicates that the `Table` is converted into a sink which 
is not the case.
    
    - [X] General
    - [X] Documentation
    - [X] Tests & Build


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fhueske/flink tableToSink

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2023.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2023
    
----

----


> Change Table.toSink() to Table.writeToSink()
> --------------------------------------------
>
>                 Key: FLINK-3955
>                 URL: https://issues.apache.org/jira/browse/FLINK-3955
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API
>    Affects Versions: 1.1.0
>            Reporter: Fabian Hueske
>            Assignee: Fabian Hueske
>
> Currently, a {{Table}} can be emitted to a {{TableSink}} using the 
> {{Table.toSink()}} method.
> However, the name of the method indicates that the {{Table}} is converted 
> into a {{Sink}}.
> Therefore, I propose to change the method to {{Table.writeToSink()}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to