[
https://issues.apache.org/jira/browse/FLINK-3728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15297812#comment-15297812
]
ASF GitHub Bot commented on FLINK-3728:
---------------------------------------
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/2018#issuecomment-221185294
Also looks good! +1.
> Throw meaningful exceptions for unsupported SQL features
> --------------------------------------------------------
>
> Key: FLINK-3728
> URL: https://issues.apache.org/jira/browse/FLINK-3728
> Project: Flink
> Issue Type: Bug
> Components: Table API
> Affects Versions: 1.1.0
> Reporter: Vasia Kalavri
> Assignee: Fabian Hueske
>
> We must explicitly exclude unsupported SQL features such as Grouping Sets
> from being translated to Flink programs.
> Otherwise, the resulting program will compute invalid results.
> For that we must restrict the Calcite rules that translate Logical
> {{RelNodes}} into {{DataSetRel}} or {{DataStreamRel}} nodes.
> We may only translate to {{DataSetRel}} or {{DataStreamRel}} nodes if these
> support the semantics of the {{RelNode}}.
> Not translating a {{RelNode}} will yield a Calcite {{CannotPlanException}}
> that we should catch and enrich with a meaningful error message.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
