Myasuka commented on a change in pull request #16183:
URL: https://github.com/apache/flink/pull/16183#discussion_r654121018
##########
File path: flink-dist/src/main/resources/flink-conf.yaml
##########
@@ -107,7 +107,18 @@ parallelism.default: 1
#==============================================================================
# The backend that will be used to store operator state checkpoints if
-# checkpointing is enabled.
+# checkpointing is enabled. Checkpointing is enabled when
execution.checkpointing.interval > 0.
+#
+# Execution checkpointing related parameters.
+#
+# execution.checkpointing.interval: -1
+# execution.checkpointing.externalized-checkpoint-retention:
[DELETE_ON_CANCELLATION, RETAIN_ON_CANCELLATION]
+# execution.checkpointing.max-concurrent-checkpoints: 1
+# execution.checkpointing.min-pause: 0
+# execution.checkpointing.mode: [EXACTLY_ONCE, AT_LEAST_ONCE]
+# execution.checkpointing.timeout: 600000
Review comment:
I think a more readable value `10 min` is better.
##########
File path: flink-dist/src/main/resources/flink-conf.yaml
##########
@@ -107,7 +107,18 @@ parallelism.default: 1
#==============================================================================
# The backend that will be used to store operator state checkpoints if
-# checkpointing is enabled.
+# checkpointing is enabled. Checkpointing is enabled when
execution.checkpointing.interval > 0.
+#
+# Execution checkpointing related parameters.
+#
+# execution.checkpointing.interval: -1
Review comment:
I think setting `execution.checkpointing.interval` as `-1` is illegal as
minimal checkpoint time is 10ms. Maybe we could set it as `180 s` with some
comments.
##########
File path: flink-dist/src/main/resources/flink-conf.yaml
##########
@@ -107,7 +107,18 @@ parallelism.default: 1
#==============================================================================
# The backend that will be used to store operator state checkpoints if
-# checkpointing is enabled.
+# checkpointing is enabled. Checkpointing is enabled when
execution.checkpointing.interval > 0.
+#
+# Execution checkpointing related parameters.
+#
+# execution.checkpointing.interval: -1
Review comment:
You could refer to
[CheckpointConfig#setCheckpointInterval](https://github.com/apache/flink/blob/60c7d9e77a6e9d82e0feb33f0d8bc263dddf2fd9/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/CheckpointConfig.java#L219-L227)
for more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
