cmick commented on a change in pull request #16023:
URL: https://github.com/apache/flink/pull/16023#discussion_r654999405



##########
File path: 
flink-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSourceTest.java
##########
@@ -419,6 +426,48 @@ protected Connection setupConnection() throws Exception {
         Mockito.verify(channel, Mockito.times(0)).basicQos(anyInt());
     }
 
+    @Test
+    public void testDeliveryTimeout() throws Exception {
+        source.autoAck = false;

Review comment:
       Thanks. I've cherry-picked the integration tests you implemented. Looks 
great (I've just removed a duplicated dependency - 12ea915).
   I've changed (b86d622) the deliveryTimeout test (it now basically just 
checks whether the correct method was called).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to