zicat commented on a change in pull request #16163:
URL: https://github.com/apache/flink/pull/16163#discussion_r655296873
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/calls/BridgingFunctionGenUtil.scala
##########
@@ -147,7 +146,21 @@ object BridgingFunctionGenUtil {
externalOperands,
returnType)
} else {
- generateScalarFunctionCall(ctx, functionTerm, externalOperands,
outputDataType)
+ val targetOperands = externalOperands.zip(operands).map{
+ case(targetOperand, sourceOperand) => {
+ if (sourceOperand.isInstanceOf[ExternalGeneratedExpression]) {
+ val expression =
sourceOperand.asInstanceOf[ExternalGeneratedExpression]
+ ExternalGeneratedExpression.fromGeneratedExpression(
Review comment:
ExternalGeneratedExpression is not a case class, so the method copy of
parent class GeneratedExpression create a new object is the instance of
GeneratedExpression not ExternalGeneratedExpression
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
