twalthr commented on a change in pull request #16214:
URL: https://github.com/apache/flink/pull/16214#discussion_r655361459



##########
File path: 
flink-table/flink-table-common/src/test/java/org/apache/flink/table/factories/TestDynamicTableFactory.java
##########
@@ -50,10 +50,16 @@
     public static final String IDENTIFIER = "test-connector";
 
     public static final ConfigOption<String> TARGET =
-            ConfigOptions.key("target").stringType().noDefaultValue();
+            ConfigOptions.key("target")
+                    .stringType()
+                    .noDefaultValue()
+                    .withDeprecatedKeys("deprecated-target");

Review comment:
       I agree. It should be easier to hook into the discovery process.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to